Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9600] Fix: Atomic property deadlocks issue #518

Closed
wants to merge 8 commits into from
Closed

[FSSDK-9600] Fix: Atomic property deadlocks issue #518

wants to merge 8 commits into from

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Aug 17, 2023 •
edited
Loading

Summary

  • Implemented RecurrsiveLock instead of DispatchQueue for AtomicProperty

Test plan

  • New test case added
  • The previous test should pass

Issues

https://jira.sso.episerver.net/browse/FSSDK-9600

@muzahidul-opti muzahidul-opti requested a review from jaeopt August 17, 2023 17:12
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner August 17, 2023 17:12
@muzahidul-opti muzahidul-opti changed the title Fix: Atomic property deadlocks issue [FSSDK-9600] Fix: Atomic property deadlocks issue Aug 18, 2023
@muzahidul-opti muzahidul-opti added the question Further information is requested label Aug 23, 2023
@muzahidul-opti muzahidul-opti marked this pull request as draft August 23, 2023 11:23
@lchinigioli
Copy link

Hello @muzahidul-opti - Any updates about this issue? We have forked the SDK and included this fix, and we haven't had any problems since then, but we don't feel very comfortable with that approach.
I wonder if there's any other issue/concern that prevents this to be shipped in a new SDK release?

@muzahidul-opti
Copy link
Contributor Author

muzahidul-opti commented Nov 8, 2023 •
edited
Loading

Hello @muzahidul-opti - Any updates about this issue? We have forked the SDK and included this fix, and we haven't had any problems since then, but we don't feel very comfortable with that approach. I wonder if there's any other issue/concern that prevents this to be shipped in a new SDK release?

Hi @lchinigioli, thanks for your patience. We are currently in the middle of a sprint. We will address the issue in the next sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees

@muzahidul-opti muzahidul-opti

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @lchinigioli