Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-11006] remove assign function and use spreading #979

Merged
merged 3 commits into from
Dec 25, 2024
Merged

[FSSDK-11006] remove assign function and use spreading #979

merged 3 commits into from
Dec 25, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

Test plan

  • all existing tests should pass

Issues

  • FSSDK-11006

@raju-opti raju-opti requested a review from a team as a code owner December 13, 2024 16:53
@coveralls
Copy link

coveralls commented Dec 13, 2024 •
edited
Loading

Coverage Status

coverage: 83.955% (-0.03%) from 83.983%
when pulling 48ac9d8 on raju/util-cleanup
into 787fbc0 on master.

junaed-optimizely
junaed-optimizely approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit 1adcbdb into master Dec 25, 2024
11 of 19 checks passed
@raju-opti raju-opti deleted the raju/util-cleanup branch December 25, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely