Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9966] use coveralls-next instead of coveralls #900

Merged
merged 1 commit into from
Feb 8, 2024
Merged

[FSSDK-9966] use coveralls-next instead of coveralls #900

merged 1 commit into from
Feb 8, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • use coveralls-next instead of coveralls as it depends on deprecated packages

Test plan

  • all existing tests should pass

Issues

  • FSSDK-9966

@raju-opti raju-opti requested a review from a team as a code owner February 8, 2024 14:55
@coveralls
Copy link

Coverage Status

coverage: 90.41%. remained the same
when pulling bab9e0c on raju/dep-moderate
into e765bd4 on master.

pulak-opti
pulak-opti approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@pulak-opti pulak-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit 23697c9 into master Feb 8, 2024
18 checks passed
@raju-opti raju-opti deleted the raju/dep-moderate branch February 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulak-opti pulak-opti pulak-opti approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @pulak-opti