Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9778] return last experiment when duplicate key in config #881

Merged
merged 6 commits into from
Dec 4, 2023
Merged

[FSSDK-9778] return last experiment when duplicate key in config #881

merged 6 commits into from
Dec 4, 2023

Conversation

raju-opti
Copy link
Contributor

Summary

When duplicate experiment keys are found in a datafile, SDK returns a correct experimentMap in OptimizelyConfig:

  1. the experimentMap will contain the experiment later in the datafile experiments list.
  2. add a warning log about "Duplicate experiment keys found in datafile: {key-name}"

Test plan

  • add a test for config with duplicate experiment keys

Issues

  • FSSDK-9778

@raju-opti raju-opti requested a review from a team as a code owner December 1, 2023 20:38
@muzahidul-opti
Copy link

LGTM. FSC is failing, is it expected?

@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited
Loading

Coverage Status

coverage: 90.387% (-0.02%) from 90.405%
when pulling d3a75ba on raju/duplicate-exp
into d8daa0c on master.

muzahidul-opti
muzahidul-opti approved these changes Dec 4, 2023
View reviewed changes
Copy link

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikechu-optimizely
mikechu-optimizely approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions below, but otherwise once resolved LGTM.

lib/core/optimizely_config/index.ts Show resolved Hide resolved
lib/core/project_config/project_config_manager.ts Outdated Show resolved Hide resolved
lib/core/project_config/project_config_manager.ts Outdated Show resolved Hide resolved
@raju-opti raju-opti merged commit fc1efa0 into master Dec 4, 2023
14 of 18 checks passed
@raju-opti raju-opti deleted the raju/duplicate-exp branch December 4, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzahidul-opti muzahidul-opti muzahidul-opti approved these changes

@jaeopt jaeopt Awaiting requested review from jaeopt

@mikechu-optimizely mikechu-optimizely Awaiting requested review from mikechu-optimizely

Assignees

@jaeopt jaeopt

@mikechu-optimizely mikechu-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raju-opti @muzahidul-opti @coveralls @mikechu-optimizely @jaeopt