stop importing cats.Functor in gen lens macros #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzief
force-pushed
the
fix/genlens-functor
branch
from
47ce0db to
bc1f323
Compare
|
Nice, I haven't thought about this issue at all. Do you want us to make a bug release? |
|
Yes please, I'm kinda blocked by this. Thank you! |
Closed
|
We are having some issues regarding binary compatibility (see #795) Once we fix it, we will cut 2.0.1. I will let you know when it is ready. |
fthomas
reviewed
Jan 9, 2020
| override def modifyF[$F[_]: Functor](f: $aTpe => $F[$bTpe])(s: $sTpe): $F[$tTpe] = | ||
| Functor[$F].map(f(s.$fieldMethod))(a => s.copy($field = a)) | ||
| override def modifyF[$F[_]: cats.Functor](f: $aTpe => $F[$bTpe])(s: $sTpe): $F[$tTpe] = | ||
| cats.Functor[$F].map(f(s.$fieldMethod))(a => s.copy($field = a)) |
There was a problem hiding this comment.
For macro hygiene wouldn't it be better if this were fully qualified, i.e. _root_.cats.Functor? I guess the same applies to the import of monocle.PLens which should probably be import _root_.monocle.PLens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #792