Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiwan dhcp6c - dhcpdv6 changes #4102

Conversation

marjohn56
Copy link
Member

@marjohn56 marjohn56 commented May 10, 2020

Pull real pd from interface_pdinfo file. Need to work on dhcpd.inc. At present it divides down the prefix quite heavily. Do we want to do that or push the full prefix size to the conf?

@marjohn56 marjohn56 changed the title Update util.inc Multiwan dhcp6c - dhcpdv6 changes May 10, 2020
Pull real pd from interface_pdinfo file.
Add reusable function for obtaining ISP PD Info and PD  length
@marjohn56 marjohn56 force-pushed the Use-pd_info-in-dhcpdv6-conf-creation branch from fc5d3c5 to c76a729 Compare May 10, 2020 10:56
PD Length is now returned from the pdlen file, no need to guess.
@marjohn56
Copy link
Member Author

It all appears to work.

@marjohn56
Copy link
Member Author

@fichtner - If you want me to send you the dhcpdv6.conf and radvd.conf files so you can check the format ask away.

@fichtner fichtner self-assigned this May 11, 2020
Adjusted to make use of new functions.
Correction to Maximum prefix delegation size, should be+1 not -1!
Removed duplicate ISP assigned prefix line
@marjohn56 marjohn56 force-pushed the Use-pd_info-in-dhcpdv6-conf-creation branch from ce673d7 to fa8b4c7 Compare May 11, 2020 16:42
@marjohn56
Copy link
Member Author

Just noticed that in RADVD.conf, in auto mode its not setting the 'DepricatePrefix on option', which then took me to this - radvd-project/radvd#91

If this is true then we need to fix that.

@marjohn56
Copy link
Member Author

Additional note from Maurice who reports a failed test, is to migrate the no-release option. Debug cannot easily be migrated I don't think. tested again with a single interface and all good on my system.

@marjohn56
Copy link
Member Author

Maurice reports second attempt OK. He's not sure what went wrong with the first attempt but now working fine. There's a a new PR which adds the changes needed for killing and restarting dhcp6c on a norelease, debug level or duid change #4109. If we are happy that RADVD does not crash on deprecate set then I think that's next.

@marjohn56
Copy link
Member Author

bump... need these reviewed and pulled in for the next 20.7 beta.

@marjohn56
Copy link
Member Author

marjohn56 commented May 24, 2020

Looking at interfaces.php, I think we can move the prefix delegation size to become part of the send IPv6 prefix hint, i.e. only visible when the tickbox is checked. We no longer need to use the prefix delegation size itself in creating the dhcpdv6.conf as we pull that from the dhcp6c ENV variable ( that's in this commit ), its only use therefore is as part of the prefix hint. Many ISPs will ignore the prefix hint anyway, but some do honour it.

@marjohn56
Copy link
Member Author

marjohn56 commented Jun 19, 2020

Note - THIS PR is obsolete when using opnsense/dhcp6c#23. An updated PR #4178 replaces this PR.

@AdSchellevis
Copy link
Member

obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants