Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating logrus dependency to latest to resolve CVE #6511

Merged
merged 1 commit into from
Jul 25, 2023
Merged

updating logrus dependency to latest to resolve CVE #6511

merged 1 commit into from
Jul 25, 2023

Conversation

acornett21
Copy link
Contributor

Description of the change:
Updating logrus to latest version.

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@acornett21 acornett21 temporarily deployed to deploy July 24, 2023 20:55 — with GitHub Actions Inactive
@acornett21 acornett21 temporarily deployed to deploy July 24, 2023 20:55 — with GitHub Actions Inactive
@acornett21 acornett21 temporarily deployed to deploy July 24, 2023 20:55 — with GitHub Actions Inactive
@acornett21 acornett21 temporarily deployed to deploy July 24, 2023 20:55 — with GitHub Actions Inactive
@acornett21 acornett21 temporarily deployed to deploy July 24, 2023 20:55 — with GitHub Actions Inactive
@acornett21 acornett21 temporarily deployed to deploy July 24, 2023 20:55 — with GitHub Actions Inactive
rashmigottipati
rashmigottipati approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
everettraven
everettraven reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logrus changes look good to me, but does this also address the go-restful vulnerability mentioned in the issue? I'd be hesitant to close out that issue if there is still an outstanding dependency that needs updating unless we can verify we aren't affected by the CVE.

@acornett21
Copy link
Contributor Author

@everettraven You already addressed the go-restful issues in another PR, I linked that PR to the issue.

@everettraven
Copy link
Contributor

everettraven commented Jul 25, 2023 •
edited
Loading

You already addressed the go-restful issues in another PR, I linked that PR to the issue.

@acornett21 Ah thanks - I totally forgot I did that 😅

everettraven
everettraven approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@everettraven everettraven merged commit bcda275 into operator-framework:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@rashmigottipati rashmigottipati

@everettraven everettraven

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logrus and go-restful vulnerabilities in ansible-operator
3 participants
@acornett21 @everettraven @rashmigottipati