Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: enable linting and bingo management of the lint tool #1524

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grokspawn
Copy link
Contributor

Discovered that the lint make target doesn't lint anything. It only checks whether go imports are in expected grouping/ordering.

This PR introduces gci support (replacing goimports) as a targeted linter, and implements golang-linter support via a bingo-managed version.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2024
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@grokspawn grokspawn force-pushed the add-linting branch 2 times, most recently from e3d597f to 2a7814d Compare December 20, 2024 21:38
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (a0a503e) to head (b044ec9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1524   +/-   ##
=======================================
  Coverage   46.80%   46.80%           
=======================================
  Files         135      135           
  Lines       15760    15760           
=======================================
  Hits         7377     7377           
  Misses       7342     7342           
  Partials     1041     1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jordan Keister <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant