ci: updates to latest docker scripts #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
commented
Dec 7, 2023
| @@ -48,13 +48,13 @@ fi | |||
| # When non-empty, becomes the base layer including tag appropriate for the image being built. | |||
| # e.g. ghcr.io/openzipkin/java:21.0.1_p12-jre | |||
| # | |||
| # This is not required to be a base (FROM scratch) image like ghcr.io/openzipkin/alpine:3.18.5 | |||
| # This is not required to be a base (FROM scratch) image like ghcr.io/openzipkin/alpine:3.12.3 | |||
There was a problem hiding this comment.
value doesn't need to be latest. this is here just to keep the same text as the other repos
|
will fix whatever's wrong. sorry |
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates template to use latest ubuntu LTS and actions versions, as well copies in comments about why not cache ~/.docker
Applies templates via
./.github/generate_workflows