TODO

Signed-off-by: Adrian Cole <[email protected]>
openzipkin · Apr 14, 2024 · 25396a7 · 25396a7
1 parent 3e91928
commit 25396a7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/webflux6-micrometer/src/main/java/brave/example/Backend.java b/webflux6-micrometer/src/main/java/brave/example/Backend.java
@@ -12,7 +12,10 @@
 
 @EnableAutoConfiguration
 @RestController
-@Import(CustomObservationConfiguration.class)
+@Import(value = {
+    CustomObservationConfiguration.class,
+    ZipkinDiscoveryConfiguration.class
+})
 public class Backend {
 
   @GetMapping("/api")

diff --git a/webflux6-micrometer/src/main/java/brave/example/ZipkinDiscoveryConfiguration.java b/webflux6-micrometer/src/main/java/brave/example/ZipkinDiscoveryConfiguration.java
@@ -10,6 +10,7 @@
 import zipkin2.reporter.HttpEndpointSupplier;
 import zipkin2.reporter.HttpEndpointSuppliers;
 
+// TODO: make this conditional on configuration, to prevent crashes looking up Eureka.
 @Configuration(proxyBeanMethods = false)
 public class ZipkinDiscoveryConfiguration {
   @Bean HttpEndpointSupplier.Factory loadbalancerEndpoints(LoadBalancerClient loadBalancerClient) {