-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code #51
Merged
Merged
Refactor code #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored annex.py, connection.py to use newer changes - Refactored some templates to use newer variables - Black formatting for everything
This was
linked to
issues
Jul 4, 2020
Closed
Closed
rgaudin
reviewed
Jul 6, 2020
|
||
def download(self, c): | ||
if self.mooc.forum_thread != None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked this value? None
evaluates to False
but most False
value are different from None
rgaudin
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically does the following refactors -
Please note that utils.py is not fully refactored in this as adding other features/ fixing issues would involve changing that file largely. Also. currently the language is set to "eng" for the ZIM. I'll change that while fixing #49
This shall close the following - #45, #46, #43
The argument structure is now modified as follows -
Here's a test ZIM that I created -
test_2020-07.zip (Please ignore the random strings that I put for title and description)
I've matched this with what the original scraper without any changes did and they seem identical. There is a scope of improvements but we're not looking at the frontend part now. Maybe sometime later.