Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change detection of libretexts.org special pages and add log #97

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Nov 26, 2024

Fix #87

Changes: instead of using page title, analyzing html body to detect libretexts.org special pages

Tested on page mentioned in issue:

image

Also tested successfully on page 15834 of https://geo.libretexts.org

@benoit74 benoit74 self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.10%. Comparing base (1ef9614) to head (2fe399a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   49.20%   49.10%   -0.10%     
==========================================
  Files          17       17              
  Lines        1063     1065       +2     
  Branches      149      149              
==========================================
  Hits          523      523              
- Misses        529      531       +2     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the detect_special_pages branch from 385e40f to a86df2c Compare November 26, 2024 16:00
@benoit74 benoit74 marked this pull request as ready for review November 26, 2024 16:05
@benoit74 benoit74 requested a review from rgaudin November 26, 2024 16:06
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 force-pushed the assets_reliability branch 3 times, most recently from 67f0e73 to de9e0ee Compare December 6, 2024 12:26
Base automatically changed from assets_reliability to main December 6, 2024 12:28
@benoit74 benoit74 force-pushed the detect_special_pages branch from a86df2c to 2fe399a Compare December 6, 2024 12:31
@benoit74 benoit74 merged commit 7a97c59 into main Dec 6, 2024
10 checks passed
@benoit74 benoit74 deleted the detect_special_pages branch December 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detection of Index pages of libretexts.org is not reliable
2 participants