Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logger to Context #119

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Move logger to Context #119

merged 1 commit into from
Dec 16, 2024

Conversation

benoit74
Copy link
Contributor

Fix #113

@benoit74 benoit74 self-assigned this Dec 13, 2024
@benoit74 benoit74 marked this pull request as ready for review December 13, 2024 15:50
@benoit74
Copy link
Contributor Author

Failing integration test is just crap, looks like they've introduced a bad introduction at https://geo.libretextsorg ... Let's wait and see, they will probably fix it soon. Otherwise I will make the test more permissive.

@benoit74 benoit74 requested a review from rgaudin December 13, 2024 15:51
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.58%. Comparing base (362e1ce) to head (ca6e085).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/__main__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   51.51%   51.58%   +0.07%     
==========================================
  Files          20       20              
  Lines        1192     1196       +4     
  Branches      137      137              
==========================================
+ Hits          614      617       +3     
- Misses        565      566       +1     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 merged commit 21f752f into main Dec 16, 2024
9 of 10 checks passed
@benoit74 benoit74 deleted the move_logger branch December 16, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the logger to the Context
2 participants