Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Anoncreds schemas and validation #3397

Merged
merged 8 commits into from
Dec 11, 2024
Merged

fix: Anoncreds schemas and validation #3397

merged 8 commits into from
Dec 11, 2024

Conversation

DaevMithran
Copy link
Contributor

No description provided.

dbluhm
dbluhm reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Just a couple of minor points on pluggability of DID Methods and how best to handle that.

acapy_agent/wallet/did_method.py Outdated Show resolved Hide resolved
acapy_agent/wallet/routes.py Outdated Show resolved Hide resolved
dbluhm
dbluhm previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbluhm dbluhm requested a review from jamshale December 11, 2024 18:24
@jamshale
Copy link
Contributor

jamshale commented Dec 11, 2024 •
edited
Loading

Only thing i'm wondering about was why the examples and validation endpoints got changed for /revocation endpoints. These can still only handle indy objects?

Changing them for /anoncreds/revocation endpoints definitely makes sense.

@DaevMithran
Copy link
Contributor Author

Only thing i'm wondering about was why the examples and validation endpoints got changed for /revocation endpoints. These can still only handle indy objects?

Changing them for /anoncreds/revocation endpoints definitely makes sense.

Only thing i'm wondering about was why the examples and validation endpoints got changed for /revocation endpoints. These can still only handle indy objects?

Changing them for /anoncreds/revocation endpoints definitely makes sense.

@jamshale Reverted the /revocation endpoint changes. Thanks!

jamshale
jamshale approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jamshale
Copy link
Contributor

Not sure why I can't merge main into this branch with github. When it's up-to-date I'll merge it.

@jamshale
Copy link
Contributor

Sorry. Just merged a fix for the coverage reporting. I won't merge anything else if you update this one more time.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jamshale jamshale merged commit a402df0 into openwallet-foundation:main Dec 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamshale jamshale jamshale approved these changes

@dbluhm dbluhm dbluhm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaevMithran @jamshale @dbluhm