#334 Add unit tests for critical code sections [2.0] #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure more testing and better testing can be done but I think this is good enough for this task.
Only testing on python 3.11 now. The project is not compatible with 3.10.
I think the best testing is done in
test_issue_token_service.py
. It takes expected presentation payloads and assure they generate claims for valid inputs. I think this could be expanded further but it will likely come in handy as examples of how to send different payloads through the tests and will hopefully find any errors with expected functionality if a developer makes changes in theget_claims
function.Added some mock payloads which can be altered to do accurate testing and for context.
There is other testing in the acapy directory which is only somewhat useful. Still think it's nice to have for extra documentation and as a foundation for future features and proper testing.
Added a few TODO comments.
Here is the current coverage: