OpenId4VCI interoperability fixes. #823
Conversation
| data class Openid4VciTxCode( | ||
| val message: String, | ||
| val numeric: Boolean, | ||
| val length: Int |
There was a problem hiding this comment.
Do we need a separate length field, or is this the length of the "message" string? What happens if there's a mismatch?
If it's not the length of the message field, please add comments indicating what each of these fields means.
There was a problem hiding this comment.
Added references to the spec.
| @CborSerializable | ||
| data class Openid4VciTxCode( | ||
| val message: String, | ||
| val numeric: Boolean, |
There was a problem hiding this comment.
nit: Maybe rename to isNumeric? ...so it's obvious from the name that this is a booean...?
...If I hadn't seen that the type was Boolean, my initial guess would have been that this was a copy of "message," but as an integer rather than a string.
| credentialOffer is Openid4VciCredentialOfferPreauthorizedCode && | ||
| credentialOffer.txCode != null) { | ||
| val message = "<p>" + | ||
| credentialOffer.txCode!!.message.replace("<", "<") + |
There was a problem hiding this comment.
I see we have a htmlEscape function in AdminServlet.kt. Rather than having different hacks in different areas of the code, could we move that function to a common library/utility and reuse it here? (maybe something in identity/src/commonMain/kotlin/com/android/identity/util ?)
sorotokin
force-pushed
the
openid4vci-interop
branch
from
60a99ed to
80b0813
Compare
Signed-off-by: Peter Sorotokin <[email protected]>
sorotokin
force-pushed
the
openid4vci-interop
branch
from
80b0813 to
82e1bfb
Compare
Reworked how and when we deliver credential offer to the wallet server for openid4vci provisioning. Moved to the model where the credential offer always comes as the first evidence request/response for openid4vci. This also moves more responsibility to proofing flow handler (
FunkeProofingStatein our code, in particularperformPushedAuthorizationRequestmethod has been moved). This makes proofing more self-contained.Manually tested with our openid4vci server and external servers. Also tested with our hardcoded issuer.