Allow null apu or apv in OpenID4VP Response #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a wallet did not provide the apu or apv JWE header parameters in the response, the verifier would respond with status code (400). To instead allow the verifier to continue parsing the response, the apu and apv are checked to see if null and if so, are not added to the sessionTranscript. Tested manually against a modified wallet which did not set apu and apv. Signed-off-by: Suzanna Jiwani <[email protected]>
sorotokin
approved these changes
Dec 3, 2024
suzannajiwani
merged commit a366d57
into
openwallet-foundation-labs:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a wallet did not provide the apu or apv JWE header parameters in the response, the verifier would respond with status code (400). To instead allow the verifier to continue parsing the response, the apu and apv are checked to see if null and if so, are not added to the sessionTranscript.
Tested manually against a modified wallet which did not set apu and apv.