Disable verifier protocols that aren't compatible with the selected document #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzannajiwani
approved these changes
Nov 20, 2024
…ocument. Previously, we'd allow the user to select those protocols, but we'd display an error when they tried to use them. Now, if they're selected, we switch to a supported protocol and disable the incompatible ones. Tested by: - Manual testing. Signed-off-by: Kevin Deus <[email protected]>
kdeus
force-pushed
the
only_supported_protocols
branch
from
73101bd to
bf33b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd allow the user to select those protocols, but we'd display an error when they tried to use them. Now, if they're selected, we switch to a supported protocol and disable the incompatible ones.
Tested by: