Replace ScanQrDialog with the KMM ScanQrCodeDialog. #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were significant layout problems with the old QR code reader: the camera image was often misaligned, the borders were offset, the image could be squished, and the misalignment was inconsistent. The new QR code scanner looks much better behaved, though we lose the brackets that used to be there. Tested by: - Manual testing of both issuance and identity verification. - ./gradlew check - ./gradlew connectedCheck Signed-off-by: Kevin Deus <[email protected]>
kdeus
force-pushed
the
qr_scanner_misaligned
branch
from
6843d51 to
cb35f9b
Compare
davidz25
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were significant layout problems with the old QR code reader: the borders were offset, the image could be squished, the camera image was often misaligned or cut off, and the misalignment was inconsistent. The new QR code scanner looks much better behaved, though we lose the brackets that used to be there.
Tested by:
Manual testing of both issuance and identity verification.
./gradlew check
./gradlew connectedCheck
Tests pass