Fix the detected vct when parsing the input detector for claim descriptions #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzannajiwani
requested changes
Nov 20, 2024
...in/java/com/android/identity_credential/wallet/presentation/OpenID4VPPresentationActivity.kt
Outdated
Show resolved
Hide resolved
…ptions. This fixes a bug where the new naturalization_date field wasn't showing its display name correctly because we weren't detecting the credential type correctly. Tested by: - Manual testing. - ./gradlew check Signed-off-by: Kevin Deus <[email protected]>
kdeus
force-pushed
the
fix_vct_naturalization
branch
from
a1273e4 to
e5e5e85
Compare
suzannajiwani
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the new naturalization_date field wasn't showing its display name correctly because we weren't detecting the credential type correctly.
Tested by:
Manual testing.
./gradlew check
Tests pass