Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates to Proximity Sharing screens. #784

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kdeus
Copy link
Contributor

@kdeus kdeus commented Nov 19, 2024

Minor updates to the text and layout to bring them closer to the specs provided by our UX designer.

Tested by:

  • Manual testing.

  • Tests pass

@kdeus kdeus requested a review from davidz25 November 19, 2024 02:41
@kdeus kdeus force-pushed the proximity_sharing_ui branch 3 times, most recently from fac42c6 to 92bc2c4 Compare November 19, 2024 19:52
@kdeus kdeus requested a review from suzannajiwani November 19, 2024 21:18
server/src/main/resources/resources/generic/tos.html Outdated Show resolved Hide resolved
wallet/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Minor updates to the text and layout to bring them closer to the specs provided
by our UX designer.

In the case of the completion screen, the title used to mention scanning, but
many paths that reach the completion screen didn't scan anything, so I've
adjusted the text a bit.

Tested by:
- Manual testing.

Signed-off-by: Kevin Deus <[email protected]>
@kdeus kdeus force-pushed the proximity_sharing_ui branch from 92bc2c4 to 8e06bf0 Compare November 20, 2024 17:53
@kdeus kdeus merged commit 0df1745 into openwallet-foundation-labs:main Nov 20, 2024
3 checks passed
@kdeus kdeus deleted the proximity_sharing_ui branch November 20, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants