Bar codes for credential offers on our openid4vci server page. #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeus
approved these changes
Nov 18, 2024
| class QrServlet : BaseServlet() { | ||
| override fun doGet(req: HttpServletRequest, resp: HttpServletResponse) { | ||
| val str = req.getParameter("q") ?: "" | ||
| /* |
|
|
||
| val qr = Encoder.encode(str, ErrorCorrectionLevel.L, null) | ||
| val matrix = qr.matrix | ||
| val w = matrix.width |
There was a problem hiding this comment.
nit: remove w and h? We aren't using them everywhere (some places we use matrix.width and matrix.height, other places we use w and h). Let's just be consistent and always use matrix.width, matrix.height.
Or, if we want to consistently use these two variables, rename them to "width" and "height." (generally avoid abbreviations)
There was a problem hiding this comment.
Yeah, fixed this.
| */ | ||
| class QrServlet : BaseServlet() { | ||
| override fun doGet(req: HttpServletRequest, resp: HttpServletResponse) { | ||
| val str = req.getParameter("q") ?: "" |
There was a problem hiding this comment.
Do we want to do any sanity checking on the string? Check that it's not 0-length, at least? Or will Encoder.encode already do that?
There was a problem hiding this comment.
zero-length is valid, but missing parameter is worth handling rather than silently ignoring.
Signed-off-by: Peter Sorotokin <[email protected]>
sorotokin
force-pushed
the
credential_offer_issues
branch
from
4518e7b to
3dd0110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually