Display Driving Privileges in a human-friendly format. #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's what the new UI looks like in the Wallet, on the Show Data / Document Data screen: |
kdeus
force-pushed
the
driving_priviliges_ui
branch
from
ce2cc26 to
db3fba9
Compare
davidz25
approved these changes
Nov 18, 2024
wallet/src/main/java/com/android/identity_credential/wallet/DocumentDetails.kt
Show resolved
Hide resolved
wallet/src/main/java/com/android/identity_credential/wallet/ui/CommonUI.kt
Show resolved
Hide resolved
kdeus
force-pushed
the
driving_priviliges_ui
branch
from
db3fba9 to
91ab58e
Compare
This required refactoring the way we store the display data for mdoc attributes. Now, instead of mapping from human-readable name to a value string, we map from attribute name to a AttributeDisplayInfo object that includes the attribute's human-readable name and information about how to display the value. Tested by: - Manual testing. - ./gradlew check - ./gradlew connectedCheck Signed-off-by: Kevin Deus <[email protected]>
kdeus
force-pushed
the
driving_priviliges_ui
branch
from
91ab58e to
47647b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required refactoring the way we store the display data for mdoc attributes. Now, instead of mapping from human-readable name to a value string, we map from attribute name to a AttributeDisplayInfo object that includes the attribute's human-readable name and information about how to display the value.
Tested by:
Manual testing of both the wallet and appverifier.
./gradlew check
./gradlew connectedCheck
Tests pass