Add vct Field to OpenID4VP flows #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeus
approved these changes
Nov 12, 2024
identity/src/commonMain/kotlin/com/android/identity/documenttype/VcRequest.kt
Show resolved
Hide resolved
...in/java/com/android/identity_credential/wallet/presentation/OpenID4VPPresentationActivity.kt
Outdated
Show resolved
Hide resolved
Added vct field as const to the verifier, and updated wallet to send documents which match the defined vct if defined as a const. Tested manually with verifier changes + with verifiers without defined vct. Signed-off-by: Suzanna Jiwani <[email protected]>
suzannajiwani
force-pushed
the
openid4vp-vct-support
branch
from
71d6739 to
21f2d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added vct field as const to the verifier, and updated wallet to send documents which match the defined vct if defined as a const.
Tested manually with verifier changes + with verifiers without defined vct.