Presentation during issuance. #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeus
reviewed
Nov 6, 2024
server-openid4vci/src/main/java/com/android/identity/server/openid4vci/AuthorizeServlet.kt
Outdated
Show resolved
Hide resolved
server-openid4vci/src/main/java/com/android/identity/server/openid4vci/createSession.kt
Show resolved
Hide resolved
server-openid4vci/src/main/java/com/android/identity/server/openid4vci/openid4vp.kt
Outdated
Show resolved
Hide resolved
wallet/src/main/java/com/android/identity_credential/wallet/ProvisioningViewModel.kt
Outdated
Show resolved
Hide resolved
wallet/src/main/java/com/android/identity_credential/wallet/ProvisioningViewModel.kt
Outdated
Show resolved
Hide resolved
...d/identity_credential/wallet/ui/destination/provisioncredential/ProvisionCredentialScreen.kt
Show resolved
Hide resolved
Signed-off-by: Peter Sorotokin <[email protected]>
sorotokin
force-pushed
the
openid4vci-pid-auth
branch
from
c35b3d2 to
a248e6a
Compare
|
We discussed factoring out openid4vp code with David. We need to create identity-openid library and move all the related code there. |
kdeus
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented draft spec for presentation during issuance that adds an option for the issuing authority to request openid4vp credential presentation as evidence. This significantly improves user experience as there is no need to switch to the browser and then back to the wallet.
In our implementation we send EvidenceRequests for both openid4vp presentation and web-based evidence collection. Wallet determines if there is actually a valid credential that can be used and only offers user to do presentation during issuance if an appropriate credential is found.
Manually tested the scenarios of having and not having an appropriate PID in the wallet as well as accepting or not accepting in-wallet PID presentation.
Only narrow path for OpenId4VP presentation is implemented: PID in mdoc format. OpenId4VP code should be factored out in a separate library that can be used in the wallet, verifier and OpenId4VCI issuer.