Fix String.fromBase64Url() extension. #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidz25
force-pushed
the
fix-base64-bug
branch
from
19cf25e to
bfbb27c
Compare
kdeus
reviewed
Nov 5, 2024
identity/src/commonMain/kotlin/com/android/identity/document/Document.kt
Outdated
Show resolved
Hide resolved
Turns out that Base64.UrlSafe.decode() changed its behavior in Kotlin 2.0 and we missed this and EU PID documents no longer has SD-JWT VC credentials as a result. The root problem is that Base64.UrlSafe.decode() no longer ignores padding and our API contract in String.fromBase64Url() extension says it will. Fix this by using withPadding(PaddingOption.ABSENT_OPTIONAL) available in Kotlin 2.0.21. See https://youtrack.jetbrains.com/issue/KT-69846 for more details. Test: EU PID now has SD-JWT VC credentials again. Signed-off-by: David Zeuthen <[email protected]>
davidz25
force-pushed
the
fix-base64-bug
branch
from
bfbb27c to
381d739
Compare
sorotokin
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that Base64.UrlSafe.decode() changed its behavior in Kotlin 2.0 and we missed this and EU PID documents no longer has SD-JWT VC credentials as a result.
The root problem is that Base64.UrlSafe.decode() no longer ignores padding and our API contract in String.fromBase64Url() extension says it will. Fix this by using withPadding(PaddingOption.ABSENT_OPTIONAL) available in Kotlin 2.0.21.
See https://youtrack.jetbrains.com/issue/KT-69846 for more details.
Also fix errornous credential.delete() call in the catch handler invoked when that call had already thrown.
Test: EU PID now has SD-JWT VC credentials again.