Send a single image as evidence, rather than the whole video. #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recording a selfie, if the video was too long, the app would run out of memory when trying to send the video to the issuer. Now this sends a single front-facing image instead. Tested by: - Manual testing, recording selfies as evidence. - ./gradlew connectedCheck - ./gradlew check Signed-off-by: Kevin Deus <[email protected]>
davidz25
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording a selfie, if the video was too long, the app would run out of memory when trying to send the video to the issuer. Now this sends a single front-facing image instead.
Tested by:
Manual testing, recording selfies as evidence, including a long video.
./gradlew connectedCheck
./gradlew check
Tests pass