Fix handling of a deleted doc, so the error message to the user is clearer #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earer. Added a null check so the code ends up displaying a message to the user, "No available documents can fulfill the request," rather than the generic, "An error has occurred." This hits when running OpenID4VP verification from the verifier server to an empty wallet. Signed-off-by: Kevin Deus <[email protected]>
davidz25
approved these changes
Oct 31, 2024
kdeus
added a commit
to kdeus/identity-credential
that referenced
this pull request
Oct 31, 2024
…earer. (openwallet-foundation-labs#766) Added a null check so the code ends up displaying a message to the user, "No available documents can fulfill the request," rather than the generic, "An error has occurred." This hits when running OpenID4VP verification from the verifier server to an empty wallet. Signed-off-by: Kevin Deus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a null check so the code ends up displaying a message to the user, "No available documents can fulfill the request," rather than the generic, "An error has occurred."
This hits when running OpenID4VP verification from the verifier server to an empty wallet.
Tested by:
Fixes #763