Refactor consent prompt and move it to identity-appsupport. #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidz25
force-pushed
the
rework-consent-dialog
branch
6 times, most recently
from
9a5ac88 to
87dd8af
Compare
kdeus
approved these changes
Oct 9, 2024
.../src/commonMain/kotlin/com/android/identity/appsupport/ui/consent/ConsentModalBottomSheet.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/android/identity/appsupport/ui/consent/ConsentModalBottomSheet.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/android/identity/appsupport/ui/consent/ConsentModalBottomSheet.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/android/identity/appsupport/ui/consent/ConsentModalBottomSheet.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/android/identity/appsupport/ui/consent/ConsentModalBottomSheet.kt
Outdated
Show resolved
Hide resolved
wallet/src/main/java/com/android/identity_credential/wallet/ui/prompt/consent/ConsentPrompt.kt
Outdated
Show resolved
Hide resolved
...stapp/src/commonMain/kotlin/com/android/identity/testapp/ui/ConsentModalBottomSheetScreen.kt
Outdated
Show resolved
Hide resolved
...stapp/src/commonMain/kotlin/com/android/identity/testapp/ui/ConsentModalBottomSheetScreen.kt
Show resolved
Hide resolved
.../src/main/java/com/android/identity_credential/wallet/credman/CredmanPresentationActivity.kt
Show resolved
Hide resolved
...in/java/com/android/identity_credential/wallet/presentation/OpenID4VPPresentationActivity.kt
Outdated
Show resolved
Hide resolved
- Add support for `intentToRetain` and add new sample requests to identity-doctypes library. - Make `TrustPoint` available in multiplatform. This includes switching to using X509Cert instead of X509Certificate (which is Java-only). - Update to match design and UX in the functional specification document. - Rename to `ConsentModalBottomSheet` and for easier embedding take a `SheetState`. - Introduce `ConsentDocument` and `ConsentRelyingParty` to capture information to display in the sheet. - Fix height so it's not constant-height but dynamically adjusts according to how much content there is - Instead of disabling the "Share" button and displaying "Scroll down", turn the "Share" button into a "More" button which will scroll down. This matches the behavior in other wallets - Add support in samples/testapp for this for all the use-cases. - Use Material You in samples/testapp - Rework navigation in samples/testapp - Update some dependencies. Test: Manually tested in samples/testapp on Android and iOS. Signed-off-by: David Zeuthen <[email protected]>
davidz25
force-pushed
the
rework-consent-dialog
branch
from
87dd8af to
38e184a
Compare
|
Thanks for the review, implemented all your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intentToRetainand add new sample requests to identity-doctypes library.TrustPointavailable in multiplatform. This includes switching to using X509Cert instead of X509Certificate (which is Java-only).ConsentModalBottomSheetand for easier embedding take aSheetState.ConsentDocumentandConsentRelyingPartyto capture information to display in the sheet.Test: Manually tested in samples/testapp on Android and iOS.