Misc fixes for Austroads Test Event. #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle not having `displayName` in a Trust Point for the reader. This can happen when importing trust points from a VICAL where there's no display name. Just use the subject X500 principal name instead. Register the OWF Test IACA _after_ the VICAL so our display name and icon is actually used. Add missing description for PhotoID data element. Test: Manually tested. Signed-off-by: David Zeuthen <[email protected]>
sorotokin
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle not having
displayNamein a Trust Point for the reader. This can happen when importing trust points from a VICAL where there's no display name. Just use the subject X500 principal name instead.Register the OWF Test IACA after the VICAL so our display name and icon is actually used.
Add missing description for PhotoID data element.
Test: Manually tested.
Fixes #<issue_number_goes_here>