Initial support for SD-JWT VC. #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balfanz
approved these changes
May 6, 2024
GarethCOliver
approved these changes
May 6, 2024
identity-sdjwt/src/main/java/com/android/identity/sdjwt/Disclosure.kt
Outdated
Show resolved
Hide resolved
identity-sdjwt/src/main/java/com/android/identity/sdjwt/SdJwtVerifiableCredential.kt
Outdated
Show resolved
Hide resolved
| throw AttributeNotDisclosedException("attribute $attribute not included in disclosures") | ||
| } | ||
|
|
||
| val disclosure = matchingDisclosures[0] |
There was a problem hiding this comment.
Would multiple matches also be bad? if so singleOrNull is an elegant way to handle this
identity-sdjwt/src/main/java/com/android/identity/sdjwt/util/JwtJsonObject.kt
Outdated
Show resolved
Hide resolved
identity-sdjwt/src/main/java/com/android/identity/sdjwt/credential/SdJwtCredential.kt
Show resolved
Hide resolved
sorotokin
approved these changes
May 6, 2024
|
Thanks for the review, force-pushed some of the nit fixes! Will land this. |
This adds a new identity-sdjwt library which includes support for working with the core data structures in IETF SD-JWT and SD-JWT VCs. Future commits will add support for provisioning and presentation in the 'wallet' module. Test: New unit and all unit tests pass. Co-authored-by: David Zeuthen <[email protected]> Signed-off-by: David Zeuthen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new identity-sdjwt library which includes support for working with the core data structures in IETF SD-JWT and SD-JWT VCs. Future commits will add support for provisioning and presentation in the 'wallet' module.
Test: New unit and all unit tests pass.