Fixes for Android Keystore Capabilities on older Android devices. #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android devices shipping with versions before Android 12 are not required to set their KeyMint version number in the properties android.hardware.hardware_keystore and android.hardware.strongbox_keystore. Add code to work around this. In the Secure Area Test App, show name for API level and also show the First API Level and its name (the First API level is the API level the device shipped with). Also add code to work around Android Keystore creating software-backed keys if its Keymint version does not support the requested features. Test: Manually tested on Pixels 4XL, 4a, 7a, 7 Pro, 8 Pro.
suzannajiwani
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android devices shipping with versions before Android 12 are not required to set their KeyMint version number in the properties android.hardware.hardware_keystore and android.hardware.strongbox_keystore. Add code to work around this.
In the Secure Area Test App, show name for API level and also show the First API Level and its name (the First API level is the API level the device shipped with).
Also add code to work around Android Keystore creating software-backed keys if its Keymint version does not support the requested features.
Test: Manually tested on Pixels 4XL, 4a, 7a, 7 Pro, 8 Pro.