Conversion of package appverifier > readercertgen to Kotlin #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitrejcevski
approved these changes
Oct 27, 2023
|
|
||
| // Extensions -------------------------- | ||
| val jcaX509ExtensionUtils: JcaX509ExtensionUtils | ||
| jcaX509ExtensionUtils = try { |
There was a problem hiding this comment.
This can be defined into a single expression, like so:
val jcaX509ExtensionUtils = try {
...
} catch {
...
}
or even
the type will be inferred automatically
| return try { | ||
| // NOTE older devices may not have the right BC installed for this to work | ||
| val kpg: KeyPairGenerator | ||
| if (curve.equals("Ed25519", ignoreCase = true) || curve.equals( |
There was a problem hiding this comment.
maybe the formatting of this if can be improved, as it is a bit tricky to read it this way 🤔
I'd move the expression from || onwards in the line below, something like
if (curve.equals("Ed25519", ignoreCase = true)
|| curve.equals("Ed448", ignoreCase = true)
) {
....
}
davidz25
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #TBD (conversion to Kotlin, second intent to create this pull request...)
Conversion of package appverifier > readercertgen to Kotlin