Add new Secure Area Test App. #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidz25
force-pushed
the
android-keystore-capabilities
branch
from
fb36e46 to
fef76fd
Compare
suzannajiwani
approved these changes
Oct 27, 2023
Comment on lines
+1196
to
+1201
| * <p>In general this is implemented by examining | ||
| * <a href="https://developer.android.com/reference/android/content/pm/PackageManager#FEATURE_HARDWARE_KEYSTORE"> | ||
| * FEATURE_HARDWARE_KEYSTORE</a> and | ||
| * <a href="https://developer.android.com/reference/android/content/pm/PackageManager#FEATURE_STRONGBOX_KEYSTORE"> | ||
| * FEATURE_STRONGBOX_KEYSTORE</a> to determine the KeyMint version for both | ||
| * the normal hardware-backed keystore and - if available - the StrongBox-backed keystore. |
There was a problem hiding this comment.
just wondering what's the reasoning behind detailing implementation in the docstring?
There was a problem hiding this comment.
Each method references the conditions of the particular capability and a lot of them reference KeyMint versions. I thought it was useful to at least link to this from somewhere.
| @@ -0,0 +1,70 @@ | |||
| package com.android.identity.secure_area_test_app.ui.theme | |||
There was a problem hiding this comment.
do files like this (+ Color.kt, Type.kt) need copyright at the top?
There was a problem hiding this comment.
Probably can't hurt. Added.
This is taken from the experimental-cloud-secure-area branch and adapted to show just AndroidKeystoreSecureArea and SoftwareSecureArea (will rebase that branch for all three secure areas once this is merged). Also rework how Android Keystore capabilities are reported and show these in the UI in the new SA test app. Since it's now possible to test AndroidKeystoreSecureArea under various conditions (for example when a Secure Lock Screen has not been set up) it's easier to verify our error handling paths. To that end, fix up propogated exceptions so they are easier to parse from the top-level exception message and not just the cause. Test: Manually tested
davidz25
force-pushed
the
android-keystore-capabilities
branch
from
fef76fd to
1f020f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taken from the experimental-cloud-secure-area branch and adapted to show just AndroidKeystoreSecureArea and SoftwareSecureArea (will rebase that branch for all three secure areas once this is merged).
Also rework how Android Keystore capabilities are reported and show these in the UI in the new SA test app.
Since it's now possible to test AndroidKeystoreSecureArea under various conditions (for example when a Secure Lock Screen has not been set up) it's easier to verify our error handling paths. To that end, fix up propogated exceptions so they are easier to parse from the top-level exception message and not just the cause.
Test: Manually tested