Make mdoc Session Encryption work with all nine KA curves. #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidz25
added
library
suzannajiwani
approved these changes
Oct 18, 2023
appverifier/src/main/java/com/android/mdl/appreader/MainActivity.kt
Outdated
Show resolved
Hide resolved
Change from "Ephemeral Key Curve" to "Session Encryption Curve" in preferences since that's more accurate. Also show which mdoc Session Encryption curve was used in the reader. Fix "Show debugging logs" buttons in both wallet and reader app (currently a no-op). Add new unit tests for COSE_Key encode and decode. Also fix mdoc MAC authentication to make it use the reader public key. Test: New unit tests + all unit tests pass. Test: Manually tested all nine curves with 18013-5 presentations.
davidz25
force-pushed
the
fix-session-encryption
branch
from
4c02f0d to
8141569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from "Ephemeral Key Curve" to "Session Encryption Curve" in preferences since that's more accurate.
Also show which mdoc Session Encryption curve was used in the reader.
Fix "Show debugging logs" buttons in both wallet and reader app (currently a no-op).
Add new unit tests for COSE_Key encode and decode.
Also fix mdoc MAC authentication to make it use the reader public key.
Test: New unit tests + all unit tests pass.
Test: Manually tested all nine curves with 18013-5 presentations.