Introduce IC Wallet and IC Purse Flavors for Holder #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitrejcevski
force-pushed
the
feat/introduce-holder-flavors
branch
from
e9ba6e7 to
c17a228
Compare
davidz25
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362
This PR introduces a second instance of the holder app that can coexist on the same device along with the regular holder app, as a separate flavor. From now on we have 2 flavors (check the screenshot below):
One can run the desired flavor by choosing it in the BuildVariants window inside the Android Studio.
This PR also renames the package holder package from
com.android.mdl.apptocom.android.identity.wallet