Update wwwverifier to recent CD consultation #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzannajiwani
force-pushed
the
issue-350
branch
2 times, most recently
from
64c9904 to
c3474e6
Compare
suzannajiwani
force-pushed
the
issue-350
branch
from
c3474e6 to
90ae45d
Compare
davidz25
reviewed
Sep 6, 2023
...d/src/main/java/com/android/identity/android/mdoc/deviceretrieval/DeviceRetrievalHelper.java
Outdated
Show resolved
Hide resolved
identity/src/main/java/com/android/identity/mdoc/origininfo/OriginInfoWebsite.java
Outdated
Show resolved
Hide resolved
suzannajiwani
changed the title
suzannajiwani
force-pushed
the
issue-350
branch
2 times, most recently
from
9105f3c to
4ac5aa4
Compare
davidz25
reviewed
Sep 14, 2023
| generator.setOriginInfos(mReverseEngagementOriginInfos); | ||
| if (mReverseEngagementOriginInfos.size() != 0) { | ||
| generator.setOriginInfos(mReverseEngagementOriginInfos); | ||
| } |
There was a problem hiding this comment.
I think it's valid to call this with an empty list, no? IOW, I think the check is superfluous...
identity/src/main/java/com/android/identity/mdoc/origininfo/OriginInfoBaseUrl.java
Outdated
Show resolved
Hide resolved
identity/src/main/java/com/android/identity/mdoc/origininfo/OriginInfo.java
Outdated
Show resolved
Hide resolved
identity/src/main/java/com/android/identity/mdoc/origininfo/OriginInfoBaseUrl.java
Outdated
Show resolved
Hide resolved
wwwverifier/src/main/java/com/android/identity/wwwreader/RequestServlet.java
Outdated
Show resolved
Hide resolved
Modified build scripts to make wwwverifier a subproject of the Identity Credential project to reduce copy-pasted code. Updated OriginInfo to match 18013-7 recent CD consultation. Tested appholder changes manually with unattended presentations via the wwwverifier as well as attended presentations with appverifier.
suzannajiwani
force-pushed
the
issue-350
branch
from
4ac5aa4 to
55ef22a
Compare
davidz25
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified build scripts to make wwwverifier a subproject of the Identity Credential project to reduce copy-pasted code. Updated OriginInfo to match 18013-7 WD6 updates.
Tested appholder changes manually with unattended presentations via the wwwverifier as well as attended presentations with appverifier.
Fixes #350