Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yolov9 notebook #1758

Merged
merged 6 commits into from
Feb 29, 2024
Merged

yolov9 notebook #1758

merged 6 commits into from
Feb 29, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Feb 26, 2024

Ticket: CVS-133798

  • text
  • README
  • inference on video

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@eaidova eaidova marked this pull request as ready for review February 28, 2024 06:19
@eaidova eaidova requested review from a team, apaniukov, itrushkin and aleksandr-mokrov and removed request for a team February 28, 2024 06:41
Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

MaximProshin commented on 2024-02-28T09:27:53Z
----------------------------------------------------------------

accept => accepts


Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

MaximProshin commented on 2024-02-28T09:27:54Z
----------------------------------------------------------------

yolov7 => yolov9


Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

MaximProshin commented on 2024-02-28T09:27:55Z
----------------------------------------------------------------

Line #11.        Preprocess image according to YOLOv7 input requirements. 

YOLOv7 => YOLOv9


Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

MaximProshin commented on 2024-02-28T09:27:56Z
----------------------------------------------------------------

Line #9.        OpenVINO YOLOv7 model inference function. Reads image, preprocess it, runs model inference and postprocess results using NMS.

YOLOv7 => YOLOv9


Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

MaximProshin commented on 2024-02-28T09:27:57Z
----------------------------------------------------------------

prepare => prepares


Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

MaximProshin commented on 2024-02-28T09:27:57Z
----------------------------------------------------------------

YOLOv7 => YOLOv9


Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

MaximProshin commented on 2024-02-28T09:27:58Z
----------------------------------------------------------------

Line #1.    quantized_model = nncf.quantize(ov_model, quantization_dataset, preset=nncf.QuantizationPreset.MIXED)

let's add the check if int8 model already exists


@eaidova eaidova force-pushed the ea/yolov9 branch 2 times, most recently from cd73999 to 4c803f4 Compare February 28, 2024 10:44
Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

itrushkin commented on 2024-02-28T13:11:57Z
----------------------------------------------------------------

Line #23.        model(example_input)

Is this model call required?


Copy link

review-notebook-app bot commented Feb 28, 2024

View / edit / reply to this conversation on ReviewNB

itrushkin commented on 2024-02-28T13:11:58Z
----------------------------------------------------------------

Line #4.    from notebook_utils import download_file

This package is already imported in the beginning of the notebook


Copy link

review-notebook-app bot commented Feb 29, 2024

View / edit / reply to this conversation on ReviewNB

aleksandr-mokrov commented on 2024-02-29T01:46:47Z
----------------------------------------------------------------

Model Conversion API - could you provide link?


@eaidova eaidova merged commit 19485aa into openvinotoolkit:main Feb 29, 2024
14 of 15 checks passed
@eaidova eaidova deleted the ea/yolov9 branch February 29, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants