Whisper pipeline: implement 'initial_prompt' and 'hotwords' parameters #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: whisper
as-suvorov
commented
Dec 13, 2024
Comment on lines
+575
to
+576
| OPENVINO_ASSERT(!config.initial_prompt.has_value(), "'initial_prompt' parameter is not supported on NPU device."); | ||
| OPENVINO_ASSERT(!config.hotwords.has_value(), "'hotwords' parameter is not supported on NPU device."); |
There was a problem hiding this comment.
@TolyaTalamanov
I wanted to add support of both parameters to static pipeline, but realized it could affect first token performance.
We need to increase decoder input size from 4 to say half of max window (448/2):
https://github.com/openvinotoolkit/openvino.genai/pull/1378/files#diff-d12890f3f3d40e33557c7aa7fd3b13593d022cb3921484837159ccf9a6e48d4aR548
reshape_to_static(decoder_model, 4, 4, last_hidden_state_shape); -> reshape_to_static(decoder_model, 448/2, 448/2, last_hidden_state_shape);
As I understand this could reduce performance in case of neither initial_prompt nor hotwords are set.
ilya-lavrenov
approved these changes
Dec 16, 2024
Wovchena
requested changes
Dec 16, 2024
Wovchena
requested changes
Dec 18, 2024
Wovchena
approved these changes
Dec 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
initial_promptparameter (faster_whisper reference) - injects initial prompt tokens as a previous transcription into the first processing windowhotwordsparameter (faster_whisper reference) - injects hotwords tokens as a previous transcription into the all processing windowsCloses #1150
Ticket: 156888