-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label groups for hierarchical classification in ImageNet #1645
Add label groups for hierarchical classification in ImageNet #1645
Conversation
Signed-off-by: Ilya Trushkin <[email protected]>
Signed-off-by: Ilya Trushkin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1645 +/- ##
===========================================
+ Coverage 81.06% 81.22% +0.16%
===========================================
Files 278 281 +3
Lines 32517 32889 +372
Branches 6607 5291 -1316
===========================================
+ Hits 26360 26715 +355
- Misses 4701 4723 +22
+ Partials 1456 1451 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @itrushkin, could you add parent information for each label?
For instance,
LabelCategories.Category(name='Clover', parent='', attributes=set()), LabelCategories.Category(name='Clover/Ace', parent='', attributes=set())
should be turned into
LabelCategories.Category(name='Clover', parent='', attributes=set()), LabelCategories.Category(name='Clover/Ace', parent='Clover', attributes=set())
Signed-off-by: Ilya Trushkin <[email protected]>
Signed-off-by: Ilya Trushkin <[email protected]>
@wonjuleee Parent category property is implemented in daf6669 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your efforts!
Summary
This PR adds grouping of labels (directories for the ImageNet case) by their groups (parent directories).
For example, for the following folder structure
label groups will be
label_1
andlabel_2
.Note: for the higher depth of nesting, names of groups will be relative paths of second-to-last directories. For the following case:
label groups will be
label_1/label_1_1
andlabel_2/label_2_1
.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.