Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KITTI 3D format #1619

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Sep 24, 2024

Summary

  • Ticket no.151424
  • Support KITTI 3D format

How to test

  • Add unit test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex changed the base branch from develop to releases/1.9.0 September 24, 2024 09:41
@sooahleex sooahleex force-pushed the feat/add_kitti_3d branch 2 times, most recently from bff3d4c to 0148c35 Compare September 25, 2024 02:00
@sooahleex sooahleex changed the base branch from releases/1.9.0 to develop September 25, 2024 02:03
@sooahleex sooahleex force-pushed the feat/add_kitti_3d branch 2 times, most recently from a84eaa6 to 2e98d7f Compare September 25, 2024 05:36
@sooahleex sooahleex marked this pull request as ready for review September 25, 2024 05:41
@sooahleex sooahleex requested review from a team as code owners September 25, 2024 05:41
@sooahleex sooahleex requested review from itrushkin and removed request for a team September 25, 2024 05:41
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 82.82828% with 17 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (ff5fd94) to head (e373879).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/datumaro/plugins/data_formats/kitti_3d/base.py 80.00% 10 Missing and 3 partials ⚠️
...datumaro/plugins/data_formats/kitti_3d/importer.py 85.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1619      +/-   ##
===========================================
+ Coverage    81.06%   81.10%   +0.04%     
===========================================
  Files          278      281       +3     
  Lines        32517    32713     +196     
  Branches      6607     6633      +26     
===========================================
+ Hits         26360    26532     +172     
- Misses        4701     4721      +20     
- Partials      1456     1460       +4     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.09% <82.82%> (+0.04%) ⬆️
windows-2022_Python-3.10 81.08% <82.82%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee merged commit c4d7bb4 into openvinotoolkit:develop Sep 25, 2024
5 checks passed
@kprokofi
Copy link

kprokofi commented Sep 25, 2024

@sooahleex @wonjuleee
Thanks for providing this dataset format.
I found 1 stopper issue. Currently, this dataset cannot detect subsets. To align it with other datasets, I would ask you to add possibility to detect subfolders like:
image

Currently, if I even iterate over subsets and create Datumaro datasets, each for each subset, it will lead to labels mismatch and it cannot be used, unfortunately:
image
image
As you can see, labels for train and val are with different indexes.

@kprokofi
Copy link

kprokofi commented Sep 25, 2024

@sooahleex One more serious problem:
that media (or image) is something weird.
image
In KITTI datatset image is just a .png file, not PointCloud and the path to that file is also weird. Could you take a look and fix that as well?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants