Update cvat format doc to bypass warning #1177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openvinotoolkit#1145) - Add multi-threading option (`num_workers > 0`) to `ModelTransform` and `SAMBboxToInstanceMask`. - It is required if the model launcher can take multiple requests at the same time and have high throughput. Signed-off-by: Kim, Vinnam <[email protected]>
…it#1149) - One of the tests added in openvinotoolkit#1145 is flaky: https://github.com/openvinotoolkit/datumaro/actions/runs/6156803415/job/16706221640 ```console =========================== short test summary info ============================ FAILED tests/unit/test_util.py::MultiProcUtilTest::test_raise_exception_in_main_thread = 1 failed, 1493 passed, 38 skipped, 2 xfailed, 48148 warnings in 407.34s (0:06:47) = tests-py38-darwin: exit 1 (462.14 seconds) /Users/runner/work/datumaro/datumaro> python -m pytest -v --csv=/Users/runner/work/datumaro/datumaro/.tox/results-tests-py38-darwin.csv tests/unit --cov --cov-report=xml pid=4536 .pkg: _exit> python /Users/runner/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True setuptools.build_meta tests-py38-darwin: FAIL code 1 (793.18=setup[331.04]+cmd[462.14] seconds) evaluation failed :( (803.78 seconds) ``` - This is because `join_timeout` is too short, so that the main thread tries to assert the error logs before they are created. - To fix it, set `join_timeout=None` to wait it infinitely until the producer thread terminates. Signed-off-by: Kim, Vinnam <[email protected]>
* update changelog * update release note * update version string
* add ready_for_review status to the pr-test workflow triggering condition
<!-- Contributing guide: https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md --> ### Summary Regarding Issue openvinotoolkit#1147 , modify coco exporter to be able to export annotations even if there's no media. Annotations which need media information will be skipped as same as before. <!-- Resolves openvinotoolkit#111 and openvinotoolkit#222. Depends on openvinotoolkit#1000 (for series of dependent commits). This PR introduces this capability to make the project better in this and that. - Added this feature - Removed that feature - Fixed the problem openvinotoolkit#1234 --> ### How to test <!-- Describe the testing procedure for reviewers, if changes are not fully covered by unit tests or manual testing can be complicated. --> ### Checklist <!-- Put an 'x' in all the boxes that apply --> - [x] I have added unit tests to cover my changes. - [ ] I have added integration tests to cover my changes. - [x] I have added the description of my changes into [CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md). - [ ] I have updated the [documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs) accordingly ### License - [x] I submit _my code changes_ under the same [MIT License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. - [ ] I have updated the license header for each file (see an example below). ```python # Copyright (C) 2023 Intel Corporation # # SPDX-License-Identifier: MIT ```
fix link to transforms.py to match changed directory structure
- Fixed broken YOLO-ultralytics links that were referring to the format specifications on GitHub. The source files were apparently changed, thus links became invalid.
- Ticket no. 120781. Signed-off-by: Kim, Vinnam <[email protected]> Co-authored-by: Wonju Lee <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cvatformatHow to test
Checklist
License
Feel free to contact the maintainers if that's a concern.