Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken YOLO ultralytics links #1161

Merged

Conversation

daniilpastukhov
Copy link
Contributor

Summary

  • Fixed broken YOLO-ultralytics links that were referring to the format specifications on GitHub. The source files were apparently changed, thus links became invalid.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@daniilpastukhov daniilpastukhov requested review from a team as code owners October 2, 2023 00:25
@daniilpastukhov daniilpastukhov requested review from vinnamkim and removed request for a team October 2, 2023 00:25
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interests on our project! LGTM.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e03768b) 80.01% compared to head (1b5ca89) 80.01%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1161   +/-   ##
========================================
  Coverage    80.01%   80.01%           
========================================
  Files          266      266           
  Lines        29967    29967           
  Branches      5901     5901           
========================================
  Hits         23978    23978           
  Misses        4632     4632           
  Partials      1357     1357           
Flag Coverage Δ
macos-11_Python-3.8 79.13% <ø> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 80.00% <ø> (ø)
windows-2019_Python-3.8 79.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinnamkim vinnamkim merged commit f951be0 into openvinotoolkit:develop Oct 4, 2023
6 checks passed
@vinnamkim vinnamkim mentioned this pull request Oct 6, 2023
6 tasks
vinnamkim added a commit that referenced this pull request Oct 16, 2023
- Apply fixes to 1.5.1 from #1159 and #1161

Signed-off-by: Kim, Vinnam <[email protected]>
Co-authored-by: Matěj Šmíd <[email protected]>
Co-authored-by: Daniil Pastukhov <[email protected]>
yunchu pushed a commit to yunchu/datumaro that referenced this pull request Oct 23, 2023
- Apply fixes to 1.5.1 from openvinotoolkit#1159 and openvinotoolkit#1161

Signed-off-by: Kim, Vinnam <[email protected]>
Co-authored-by: Matěj Šmíd <[email protected]>
Co-authored-by: Daniil Pastukhov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants