Skip to content

Commit

Permalink
No security check for id_from_image_name (#1642)
Browse files Browse the repository at this point in the history
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary
Ignore bandit error B311 in 'id_from_image_name' transform.

<!--
Resolves #111 and #222.
Depends on #1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem #1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [ ] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
  • Loading branch information
Jihyeon Yi authored Oct 15, 2024
1 parent 964387f commit 054bd95
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/datumaro/plugins/transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,9 @@ def __init__(self, extractor, ensure_unique: bool = False, suffix_length: int =
def _add_unique_suffix(self, name):
count = 0
while name in self._names:
suffix = "".join(random.choices(self.SUFFIX_LETTERS, k=self._suffix_length))
suffix = "".join(
random.choices(self.SUFFIX_LETTERS, k=self._suffix_length)
) # nosec B311
new_name = f"{name}__{suffix}"
if new_name not in self._names:
name = new_name
Expand Down

0 comments on commit 054bd95

Please sign in to comment.