Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket autoconfig startup failure caused by Spring Messaging 5.3.2 #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

countableSet
Copy link
Contributor

  • Replace usage of WebSocketMessageBrokerConfigurationSupport to access the client inbound/outbound channels with the beans directly since there are no factories or decorators to customize these channels.
  • ChannelInterceptorAdapter deprecation warning Deprecated as of 5.0.7 ChannelInterceptor has default methods (made possible by a Java 8 baseline) and can be implemented directly without the need for this no-op adapter. Replaced with the suggested action.
  • AbstractWebSocketMessageBrokerConfigurer deprecation warning Deprecated as of 5.0 in favor of simply using WebSocketMessageBrokerConfigurer which has default methods, made possible by a Java 8 baseline.. Replaced with the suggested action.

relates to issue #308

@QBrute
Copy link

QBrute commented Feb 3, 2021

Hi @countableSet , what's the status of this one? I see there are failed tests, so I guess that's why the PR can't be merged?

@countableSet
Copy link
Contributor Author

hi @MaxMega 👋🏻 master was having some issues at the time (https://travis-ci.org/github/opentracing-contrib/java-spring-cloud/jobs/755557498). It looked like the same error in this pr as in master. So still waiting on that to be fixed before running the tests again. Not sure why this pr can't be merged. I think the maintainers haven't looked at it yet?

@QBrute
Copy link

QBrute commented Feb 14, 2021

Hi @countableSet sorry that I'm replying so late. It seems that the error is caused by io.opentracing.contrib:opentracing-spring-cloud-parent:pom:0.5.8-SNAPSHOT not being found.

There is a Version 0.5.8, but it's not marked as SNAPSHOT, so maybe that's the problem here. https://search.maven.org/artifact/io.opentracing.contrib/opentracing-spring-cloud-parent/0.5.8/pom

@countableSet
Copy link
Contributor Author

Looks like this #317 fixes the build issue.

@dogukancagatay
Copy link

Can we get this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants