Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest] add coprocessor version string API #2602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

puddly
Copy link

@puddly puddly commented Nov 14, 2024

We'd like to access the current NCP/RCP coprocessor firmware version string from the REST API. I've added a new API endpoint under /node/coprocessor/version that fetches it with GetCoprocessorVersion().

}
else
{
ErrorHandler(aResponse, HttpStatusCode::kStatusMethodNotAllowed);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can have a refactor to these resource handlers to return whether the request is successfully processed so that this error can be responded in one place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean in this specific PR or in general?

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (2b41187) to head (baf9f4e).
Report is 885 commits behind head on main.

Files with missing lines Patch % Lines
src/rest/resource.cpp 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2602      +/-   ##
==========================================
- Coverage   55.77%   45.92%   -9.86%     
==========================================
  Files          87      106      +19     
  Lines        6890    12608    +5718     
  Branches        0      914     +914     
==========================================
+ Hits         3843     5790    +1947     
- Misses       3047     6502    +3455     
- Partials        0      316     +316     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants