Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for match patterns in LocalPort conditional blocks #533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for match patterns in LocalPort conditional blocks #533

wants to merge 2 commits into from

Conversation

manuelm
Copy link

@manuelm manuelm commented Nov 6, 2024

This adds support for match patterns in LocalPort conditional blocks. e.g. this now works:

Match LocalPort 22*
  SomeKeyword ...

 Match LocalPort !22,*
  SomeKeyword ...

@djmdjm
Copy link
Contributor

djmdjm commented Nov 28, 2024

Looks reasonable to me. @daztucker any objections to my committing?

@daztucker
Copy link
Contributor

Code looks OK to me, although I think it needs a regression test to go with it.

@manuelm
Copy link
Author

manuelm commented Nov 29, 2024 •
edited
Loading

Code looks OK to me, although I think it needs a regression test to go with it.

Sure, I'll add some to regress/addrmatch.sh. I've overlooked this somehow and thought there are no tests for sshd Match-blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelm @djmdjm @daztucker