Key bindings arrays for and some visualisation viewer function #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
First of all i would like to thank you for the amazing job you're making with this new bimsurfer.
I don't know if you're opened to pull requests, but you might though consider taking a look at this one.
Basically 2 proposals for viewer.js:
First, 1 array of actions that is passed to the canvas eventListener ans avoiding some if(e.key==='...' else if ...). Each action is taking a viewer method to trigger on given keypressed.
Second, i made some method for the viewer at the end of the file (like inverting visibillity, hiding unselected objects etc..)
Let me know if this kind of stuff may be of some interest to you or if not.
Happy Christmas