OCM-8679 | test: automated case id:72868 Separate the component route options when updating ingress #2157

valeriiashapoval · 2024-06-10T13:56:17Z

[valeriiashapoval@fedora rosa]$ ginkgo -focus 72868 tests/e2e/
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.14.0
  Mismatched package versions found:
    2.17.1 used by e2e

  Ginkgo will continue to attempt to run but you may see errors (including flag
  parsing errors) and should either update your go.mod or your version of the
  Ginkgo CLI to match.

  To install the matching version of the CLI run
    go install github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file.  Alternatively you can use
    go run github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file to invoke the matching version of the
  Ginkgo CLI.

  If you are attempting to test multiple packages that each have a different
  version of the Ginkgo library with a single Ginkgo CLI that is currently
  unsupported.
  
Running Suite: ROSA CLI e2e tests suite - /home/valeriiashapoval/rosa/tests/e2e
===============================================================================
Random Seed: 1718015934

Will run 3 of 102 specs
SSSSSSSSSSSS•••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 3 of 102 Specs in 72.583 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 99 Skipped
PASS

Ginkgo ran 1 suite in 1m16.88734553s
Test Suite Passed

Link to Test Cases

openshift-ci · 2024-06-10T13:59:02Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: valeriiashapoval
Once this PR has been reviewed and has the lgtm label, please assign xueli181114 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xueli181114 · 2024-06-11T03:16:32Z

Please rebase and update the commit message. The title and commit message should be
OCM-8679 | test: automated case id:72868 Separate the component route options when updating ingress

xueli181114 · 2024-06-11T03:17:56Z

tests/e2e/test_rosacli_ingress.go

+					"--component-routes", componentRoutes,
+				)
+				Expect(err).ToNot(HaveOccurred())
+				defer rosaClient.Ingress.EditIngress(clusterID,


Defer is used to recover the updated data, please not use hardcode but the recorded variable value

xueli181114 · 2024-06-11T03:18:55Z

tests/e2e/test_rosacli_ingress.go

+				output, err = rosaClient.Ingress.ListIngress(clusterID)
+				Expect(err).ToNot(HaveOccurred())
+			})
+		It("cannot update ingress components with incorrect syntax - [id:72868]",


Combine the It specs to only one. Our rule need to follow one case one It spec

xueli181114 · 2024-06-11T03:19:49Z

tests/e2e/test_rosacli_ingress.go

+				Expect(err).ToNot(HaveOccurred())
+			})
+		It("cannot update ingress components with incorrect syntax - [id:72868]",
+			labels.Medium,


For the negative cases, they should be another negative case.

ciaranRoche · 2024-07-17T13:12:22Z

@valeriiashapoval what is the current status of this MR, is it still valid?

valeriiashapoval · 2024-07-17T15:27:48Z

@valeriiashapoval what is the current status of this MR, is it still valid?

@ciaranRoche yes, testing a few minor changes and rebasing.

… options when updating ingress

openshift-ci · 2024-07-17T17:30:40Z

@valeriiashapoval: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/lint	`d603e69`	link	true	`/test lint`
ci/prow/commits	`d603e69`	link	true	`/test commits`
ci/prow/test	`d603e69`	link	true	`/test test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xueli181114 · 2024-07-19T01:02:39Z

tests/e2e/test_rosacli_ingress.go

+					"--component-routes", componentRoutes,
+				)
+				Expect(err).ToNot(HaveOccurred())
+


We usually define defer function to recover the updated value after the first edit command

xueli181114 · 2024-07-19T01:03:19Z

tests/e2e/test_rosacli_ingress.go

+				)
+				Expect(err).ToNot(HaveOccurred())
+
+				_, err = rosaClient.Ingress.EditIngress(clusterID,


Edit ingress with same parameter called twice.

xueli181114 · 2024-07-19T01:09:03Z

tests/e2e/test_rosacli_ingress.go

+
+				By("List ingress to check")
+				output, err = rosaClient.Ingress.ListIngress(clusterID)
+				Expect(err).ToNot(HaveOccurred())


Here just checked the error is not happening when list the ingress, but it didn't check the edited value showing

xueli181114 · 2024-07-19T01:09:35Z

tests/e2e/test_rosacli_ingress.go

+				Expect(err).To(HaveOccurred())
+				Expect(output.String()).Should(ContainSubstring("An error occurred whilst parsing the supplied component routes: only the name of the component should be followed by ':'"))
+
+				By("List ingress to check")


If last steps is expecting an error happen, no need to list the ingress for double checking

xueli181114 · 2024-07-19T01:09:53Z

tests/e2e/test_rosacli_ingress.go

+				Expect(err).To(HaveOccurred())
+				Expect(output.String()).Should(ContainSubstring("An error occurred whilst parsing the supplied component routes: the expected amount of component routes is 3, but 1 have been supplied"))
+
+				By("List ingress to check")


Same as above

codecov · 2024-10-08T06:13:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.92%. Comparing base (e86af7a) to head (d603e69).
Report is 689 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2157   +/-   ##
=======================================
  Coverage   26.92%   26.92%           
=======================================
  Files         151      151           
  Lines       21774    21774           
=======================================
  Hits         5862     5862           
  Misses      15462    15462           
  Partials      450      450

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

openshift-merge-robot · 2024-10-08T06:13:11Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

automate ingress component route changes - 72868

e8ecc5a

openshift-ci bot requested review from mgahagan73 and yuwang-RH June 10, 2024 13:58

xueli181114 reviewed Jun 11, 2024

View reviewed changes

Merge branch 'openshift:master' into automate-ingress-72868

472cffe

OCM-8679 | test: automated case id:72868 Separate the component route…

d603e69

… options when updating ingress

valeriiashapoval changed the title ~~[OCM-8679] | test: Automate case id - OCP-72868 - Separate the component route options when updating ingress~~ OCM-8679 | test: automated case id:72868 Separate the component route options when updating ingress Jul 17, 2024

xueli181114 reviewed Jul 19, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCM-8679 | test: automated case id:72868 Separate the component route options when updating ingress #2157

OCM-8679 | test: automated case id:72868 Separate the component route options when updating ingress #2157

valeriiashapoval commented Jun 10, 2024

openshift-ci bot commented Jun 10, 2024

xueli181114 commented Jun 11, 2024

xueli181114 Jun 11, 2024

xueli181114 Jun 11, 2024

xueli181114 Jun 11, 2024

ciaranRoche commented Jul 17, 2024

valeriiashapoval commented Jul 17, 2024

openshift-ci bot commented Jul 17, 2024

xueli181114 Jul 19, 2024

xueli181114 Jul 19, 2024

xueli181114 Jul 19, 2024

xueli181114 Jul 19, 2024

xueli181114 Jul 19, 2024

codecov bot commented Oct 8, 2024 •

edited

Loading

openshift-merge-robot commented Oct 8, 2024

OCM-8679 | test: automated case id:72868 Separate the component route options when updating ingress #2157

Are you sure you want to change the base?

OCM-8679 | test: automated case id:72868 Separate the component route options when updating ingress #2157

Conversation

valeriiashapoval commented Jun 10, 2024

openshift-ci bot commented Jun 10, 2024

xueli181114 commented Jun 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ciaranRoche commented Jul 17, 2024

valeriiashapoval commented Jul 17, 2024

openshift-ci bot commented Jul 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 8, 2024 • edited Loading

Codecov Report

openshift-merge-robot commented Oct 8, 2024

codecov bot commented Oct 8, 2024 •

edited

Loading