Merge pull request #2602 from hunterkepley/ocm-12379

OCM-12379 | fix: Duplicate commands when manual create/accountroles
openshift · Nov 7, 2024 · dd3d9d5 · dd3d9d5
2 parents 0cd254b + 900f514
commit dd3d9d5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/cmd/create/accountroles/creators.go b/cmd/create/accountroles/creators.go
@@ -354,6 +354,8 @@ func (hcp *hcpManagedPoliciesCreator) printCommands(r *rosa.Runtime, input *acco
 
 		createRole := buildCreateRoleCommand(accRoleName, file, iamTags, input)
 
+		commands = append(commands, createRole)
+
 		policyKeys := aws.GetHcpAccountRolePolicyKeys(file)
 		for _, policyKey := range policyKeys {
 			policyARN, err := aws.GetManagedPolicyARN(input.policies, policyKey)
@@ -368,7 +370,7 @@ func (hcp *hcpManagedPoliciesCreator) printCommands(r *rosa.Runtime, input *acco
 			}
 
 			attachRolePolicy := buildAttachRolePolicyCommand(accRoleName, policyARN)
-			commands = append(commands, createRole, attachRolePolicy)
+			commands = append(commands, attachRolePolicy)
 		}
 	}